[v15] Scoped WebAuthn: MFA extension flow#36973
Merged
Joerger merged 1 commit intobranch/v15from Jan 22, 2024
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
Base automatically changed from
joerger/v15/scoped-webauthn-session-data
to
branch/v15
January 20, 2024 03:07
* Use SessionData with extensions in Webauthn flow. * Pass MFAChallengeExtensions through webauthn flow. * Opportunistically enforce Webauthn challenge scope. * Don't delete webauthn session data when reuse is allowed. * Return more login data from webauthn flow. * Enforce reuse when provided by the caller. * Address comments. * Fix test. * Add unit test for scope and reuse. * use pointer for challenge extension parameters. * Address comments.
Joerger
force-pushed
the
joerger/v15/scoped-webauthn-extension-flow
branch
from
3c18586 to
8e28173
Compare
marcoandredinis
approved these changes
Jan 22, 2024
codingllama
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36667 to branch/v15
Depends on #36958